Motivation

Store modded score in database, and provide mechanism to view them

Goal

• Correctly storing the full play history, and adding an in-game history viewer
• Viewing modded lamp/scpre in-game: show corresponding lamp/score for selected mods

Implementation Details

The first goal is pretty straightforward. Creating a similar table eddatalog in scoredatalog.db, but:

• Removes the primary key, which causes scoredatalog.db file doesn't save each play record
• Adds two new fields rate and overridejudge

And by querying this table we can easily render a local history in-game using imgui. Demo:

The second goal, however, it's much complicated than first step. The most straightforward idea would be to implement the same strategy from step1: expand the definition of score table and modifies the query statements. However, it's very hard to expand the score table because its primary key is (sha256, lnmode) and it means for each chart, it stores the best score for each lnmode. Therefore, we need to expand the primary key as (sha256, lnmode, freq, override judge rank) and maintains the best score based on current selected mods and adds more fields into primary key set if we added more mods in the future.

Therefore, instead of expanding the definition of score table, this pr chose to calculate the best score based on users' full play history. Which is implemented in step1.

Compatibility

• Drop-in: nothing affected
• Backward: handled by creating a similar table instead of modifying the original table from scoredatalog.db directly. Because it would violate the primary key restriction.
• Upstream doesn't store course score into database.

Known Issues

• An incomplete play of course won't be recorded into scoredatalog but in score. Personally speaking I don't think this is an issue and need to be fixed.

TODOs:

• The second goal, allow user viewing the lamp/scores based on the selected mod directly

• Add sort & filter button for local history table

• View course scores

• Migrate old data from scoredatalog to eddatalog when it's empty Deleted because not very useful.

• Currently, the new added functions don't have the line song.hasUndefinedLongNote() ? lnmode : 3. I couldn't understand it rn. Not a thing now.

Other improvements

• Customizable columns for local history table
• Store gauge data in database (requiring a good compress algorithm)